lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4087) Provide consistent IW behavior for illegal meta data changes
Date Fri, 08 Jun 2012 08:00:26 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13291613#comment-13291613
] 

Robert Muir commented on LUCENE-4087:
-------------------------------------

I like this approach:

* I think we should not view this behavior as fixed in stone. If we decide in the future we
should
  be able to change this kind of stuff in even a minor release if we feel like it. DocValues
is a 
  *typed* field (thats its whole point!) and you shouldnt be mixing up types.
* I think we should fix this in the way you propose so we can get a 4.0 alpha release out!

Some comments:

* I think we don't need anything like this in NormsConsumer, because it looks like we have
a check
  already for this... right? Of course its much trickier for someone to changeup types there.
* I think somewhere in the documentation we should have a line of javadoc "docvalues are a
typed
  field, if you mix up types the end result is undefined". This way we don't have to commit
to
  any specific behavior as mentioned above.
                
> Provide consistent IW behavior for illegal meta data changes
> ------------------------------------------------------------
>
>                 Key: LUCENE-4087
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4087
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: core/index
>    Affects Versions: 4.0
>            Reporter: Simon Willnauer
>             Fix For: 4.0, 4.1, 5.0
>
>         Attachments: LUCENE-4087.patch
>
>
> Currently IW fails late and inconsistent if field metadata like an already defined DocValues
type or "un"-omitting norms.
> we can approach this similar to how we handle consistent field number and:
>  
> * throw exception if indexOptions conflict (e.g. omitTF=true versus
> false) instead of silently dropping positions on merge
> * same with omitNorms
> * same with norms types and docvalues types
> * still keeping field numbers consistent
> this way we could eliminate all these traps and just give an
> exception instead.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message