lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-4306) Make IR.getSequentialSubReaders() protected
Date Tue, 14 Aug 2012 00:33:38 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-4306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Uwe Schindler updated LUCENE-4306:
----------------------------------

    Attachment: LUCENE-4306.patch

Patch for trunk:
- Makes getSequentialSubReaders() protected
- Converts all tests to use leaves() when dealing with DirectoryReaders - stupid casting is
gone!
- Facet code used getSequentialSubreaders very often including summing up docBases. This is
not needed, the code now uses AtomicReaderContext and its docBase -> much cleaner code,
easier to read

Problems:
- FieldCacheSanityChecker previously looked into subreaders using getSequentialSubReaders,
which did not throw AlreadyClosedException. But getTopReaderContext() throws this exception
(which is important to prevent readers from being used by searchers when closed), so the sanity
checker can no longer visit closed readers - which it should not do in my opinion.
                
> Make IR.getSequentialSubReaders() protected
> -------------------------------------------
>
>                 Key: LUCENE-4306
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4306
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: core/index
>    Affects Versions: 4.0-BETA
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>            Priority: Blocker
>             Fix For: 5.0, 4.0
>
>         Attachments: LUCENE-4306.patch
>
>
> Followup from LUCENE-4152: The method is/should now only be used from CompositeReader's
reader context to initialize itsself. No need to call it from anywhere else.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message