lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] [Commented] (LUCENE-4322) Can we make oal.util.packed.BulkOperation* smaller?
Date Tue, 28 Aug 2012 16:54:08 GMT


Michael McCandless commented on LUCENE-4322:

Patch looks good!  That's a nice reduction.

Too bad we have to duplicate decode 4 times (from long[]/byte[] to long[]/int[]).

We could still shrink things further by doing less loop unrolling ourselves?  Eg for BulkOperationPacked2,
when decoding from byte[], that code is replicated 8 times but could be done as just 8* iters.
> Can we make oal.util.packed.BulkOperation* smaller?
> ---------------------------------------------------
>                 Key: LUCENE-4322
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Michael McCandless
>             Fix For: 5.0, 4.0
>         Attachments: LUCENE-4322.patch
> These source files add up to a lot of sources ... it caused problems when compiling under
Maven and InteliJ.
> I committed a change to make separates files, but in aggregate this is still a lot ...
> EG maybe we don't need to specialize encode?

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message