lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shawn Heisey (JIRA)" <>
Subject [jira] [Commented] (SOLR-2725) TieredMergePolicy and expungeDeletes behaviour
Date Fri, 12 Oct 2012 17:29:03 GMT


Shawn Heisey commented on SOLR-2725:

This is probably an unnecessary comment, but I wanted to be sure that when this is implemented,
it's done as a double/float so that values significantly less than 1% are possible.  It looks
like the underlying mechanism is already set up this way:

  private double forceMergeDeletesPctAllowed = 10.0;

> TieredMergePolicy and expungeDeletes behaviour
> ----------------------------------------------
>                 Key: SOLR-2725
>                 URL:
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 3.3, 3.4, 3.5, 3.6
>            Reporter: Martijn van Groningen
> During executing a commit with expungeDeletes I noticed there were still a lot of segments
> However there were still ~30 segments left with deletes after the commit finished.
> After looking in SolrIndexConfig class I noticed that TieredMergePolicy#setExpungeDeletesPctAllowed
isn't invoked.
> I think the following statements in SolrIndexConfig#buildMergePolicy method will purge
all deletes:
> {code}
> tieredMergePolicy.setExpungeDeletesPctAllowed(0);
> {code} 
> This also reflects the behavior of Solr 3.1 / 3.2
> After some discussion on IRC setting expungeDeletesPctAllowed always to zero isn't best
for performance:
> I think we should add an option to solrconfig.xml that allows users to set this option
to whatever value is best for them:
> {code:xml}
> <expungeDeletesPctAllowed>0</expungeDeletesPctAllowed>
> {code}
> Also having a expungeDeletesPctAllowed per commit command would be great:
> {code:xml}
> <commit waitFlush="false" waitSearcher="false" expungeDeletes="true" expungeDeletesPctAllowed="0"/>
> {code}

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message