lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4443) BlockPostingsFormat writes unnecessary skipdata
Date Thu, 04 Oct 2012 14:57:47 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469429#comment-13469429
] 

Robert Muir commented on LUCENE-4443:
-------------------------------------

Well this is an experimental codec (not the default format), and its likely we might change
it anyway.

I really don't like the idea of backporting optimizations to the release branch.

Nobody has to reindex if they dont want anyway, they can use addIndexes or whatever to switch
their index
back to the lucene's official index format, upgrade to 4.1, and then switch back to the new
block.

                
> BlockPostingsFormat writes unnecessary skipdata
> -----------------------------------------------
>
>                 Key: LUCENE-4443
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4443
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/codecs
>    Affects Versions: 4.0
>            Reporter: Robert Muir
>             Fix For: 4.1, 5.0
>
>         Attachments: LUCENE-4443.patch
>
>
> Seems to me lastStartOffset is unnecessary, when we skip to a document, it implicitly
is 0: see BlockPostingsWriter.startDoc.
> (Unless I'm missing something, all tests pass with "Block" if i remove it)
> Separately we should really think about lastPayloadByteUpto, is this worth it? instead
when we actually skip, we could sum the payloadLengthBuffer from 0..curPosBufferUpto as we
are going to decode that block anyway?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message