lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Commit Tag Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4566) SearcherManager.afterRefresh() issues
Date Sat, 01 Dec 2012 13:49:58 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13507963#comment-13507963
] 

Commit Tag Bot commented on LUCENE-4566:
----------------------------------------

[trunk commit] Michael McCandless
http://svn.apache.org/viewvc?view=revision&revision=1415996

LUCENE-4566: add RefreshListener to Reference/Searcher/NRTManager


                
> SearcherManager.afterRefresh() issues
> -------------------------------------
>
>                 Key: LUCENE-4566
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4566
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: selckin
>            Assignee: Michael McCandless
>            Priority: Minor
>         Attachments: LUCENE-4566-double-listeners.patch, LUCENE-4566.patch, LUCENE-4566.patch
>
>
> 1) ReferenceManager.doMaybeRefresh seems to call afterRefresh even if it didn't refresh/swap,
(when newReference == null)
> 2) It would be nice if users were allowed to override SearcherManager.afterRefresh()
to get notified when a new searcher is in action.
> But SearcherManager and ReaderManager are final, while NRTManager is not.
> The only way to currently hook into when a new searched is created is using the factory,
but if you wish to do some async task then, there are no guarantees that acquire() will return
the new searcher, so you have to pass it around and incRef manually. While if allowed to hook
into afterRefresh you can just rely on acquire()  & existing infra you have around it
to give you the latest one.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message