lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dawid Weiss (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-4169) The test suite should consistently pass
Date Wed, 12 Dec 2012 16:53:23 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13530098#comment-13530098
] 

Dawid Weiss commented on SOLR-4169:
-----------------------------------

bq. Back then, we didnt check for directories not being closed, we didnt run tests in parallel,
tests ran once a day

I agree with Mark that the restrictions put on tests have made it more difficult for the complex
stuff to pass. And every Lucene/Solr committer should try to fix at least one Solr test to
get the taste of how complex those tests are :) These aren't necessarily regressions -- they're
existing weak spots uncovered by more rigorous test sandbox rules. 

This said, I still think it'd be nice if we could somehow disable those tests that we know
produce a lot of noise and only enable them on a build plan that would run with a specific
e-mail prefix or with an entire different e-mail sink. Once somebody  decides they're ok to
be included in all plans they can do so; if builds start to fail again -- switch them back
to the "unstable" zone. Much like in-progress branches, really.
                
> The test suite should consistently pass
> ---------------------------------------
>
>                 Key: SOLR-4169
>                 URL: https://issues.apache.org/jira/browse/SOLR-4169
>             Project: Solr
>          Issue Type: Bug
>          Components: Tests
>            Reporter: Robert Muir
>            Priority: Blocker
>             Fix For: 4.1
>
>
> I'm at the end of my rope. 
> Last week I tried to help with this: but its already wednesday and solr tests are 20x
worse.
> Users are complaining that they cannot get snapshots and test them, because the tests
fail all the time.
> Maven dependencies are wrong, but we never knew, because the tests never succeeded so
the validation task hasn't actually run in months.
> I think fixing this situation is a blocker to release: I can't imagine a bigger blocker
actually.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message