lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dawid Weiss (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4630) add a system property to allow testing of suspicious stuff
Date Fri, 14 Dec 2012 08:10:12 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13532155#comment-13532155
] 

Dawid Weiss commented on LUCENE-4630:
-------------------------------------

Why does it need to be a system property, Hoss? The test group annotations can be enabled/disabled
via system properties and they also do display messages on assumption-ignored tests -- wouldn't
this be enough to cover your use case?
{code}
@SuspiciousJ9Shit
@SuspiciousJRockitShit
{code}
The only problem I see is that these need to be provided statically -- if you need to detect
them at runtime then I'd either need to change the code of the runner or we'd need to switch
to assumptions inside a rule, for example.
                
> add a system property to allow testing of suspicious stuff
> ----------------------------------------------------------
>
>                 Key: LUCENE-4630
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4630
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Hoss Man
>            Priority: Blocker
>             Fix For: 4.1
>
>
> there are times when people want to add assumptions in test to prevent confusing/false
failures in certain situations (eg: known bugs in JVM X, known incompatibilities between lucene
feature Z and filesystem Y, etc...)
> By default we want these situations to be "skiped" in tests with clear messages so that
it's clear to end users trying out releases that these tests can't be run for specific sitautions.
> But at the same time we need a way for developers to be able to try running these tests
anyway so we know if/when the underliyng problem is resolved.
> i propose we add a "tests.suspicious.shit" system property, which defaults to "false"
in the javacode, but can be set at runtime to "true"
> assumptions about things like incompatibilities with OSs, JVM vendors, JVM versions,
filesystems, etc.. can all be dependent on this system propery.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message