lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Erick Erickson (JIRA)" <>
Subject [jira] [Commented] (SOLR-4196) Untangle XML-specific nature of Config and Container classes
Date Wed, 19 Dec 2012 12:31:12 GMT


Erick Erickson commented on SOLR-4196:

I have a ConfigSolr object that I'm using that understands whether the source is xml or properties.
I'm trying to keep xml and DOM out of that and moving the bits specific to XML to Config.
It'll handle properties, and (hopefully) make it easy to nuke solr.xml by taking all the "if
(fromxml) call the Config methods, else do it myself. Sounds close enough to what you're thinking?

BTW,  I'm going to name ConfigSolr something else, suggestions? There's a SolrConfig object
already. I still remember a programming class in college where I had BlortBlivet and BlivetBlort
classes and getting them mixed up....

The hard part isn't the complexity of solr.xml, it's all the places where XML is assumed.
It's just tedious and error prone. Sure hope the tests work really, really well <G>.....

For instance, ZkController.bootstrap gets a Config object and then quite reasonably assumes
it's got access to the DOM. So that'll have to change some too. Not a lot, just a single method...

I hope by Sunday I'll have some compilable code ready to look at. If I'm lucky, I'll have
it working with the current (xml) schema and the bits for a .properties file stubbed out.
At that point I'll have something others can look at and put up a nocommit patch. I'm almost,
but not quite totally, sure that I'm going to screw something up here, I'm moving a _lot_
of code around.

On which note, merging other changes to CoreContainer is going to be...interesting...  

As you can tell I can't spend a lot of time on it each day, other commitments....
> Untangle XML-specific nature of Config and Container classes
> ------------------------------------------------------------
>                 Key: SOLR-4196
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
>            Priority: Minor
>             Fix For: 4.1, 5.0
> sub-task for SOLR-4083. If we're going to try to obsolete solr.xml, we need to pull all
of the specific XML processing out of Config and Container. Currently, we refer to xpaths
all over the place. This JIRA is about providing a thunking layer to isolate the XML-esque
nature of solr.xml and allow a simple properties file to be used instead which will lead,
eventually, to solr.xml going away.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message