lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vadim Kirilchuk (JIRA)" <>
Subject [jira] [Commented] (SOLR-1393) Allow more control over SearchComponents ordering in SearchHandler
Date Wed, 03 Apr 2013 19:59:16 GMT


Vadim Kirilchuk commented on SOLR-1393:

AFAIK apache CXF has similar thing for configuring Interceptors.
They have class, where they call
public void add(Collection<Interceptor<? extends Message>> newhandlers) {
        add(newhandlers, false);
actually they cast newhandlers to PhaseInterceptor later.

And if you look at
you will see getBefore() and getAfter() methods exactly like you want.

You also can find a source code of PhaseInterceptorChain and check method #insertInterceptor(...)
which contains tricky inserting logic. Actually they have a little bit more complex logic
then just before\after as they also have a notion of Phase for each interceptor. 

Anyway, wdyt about making things like so?

Another question is how one should configure such components ordering - through xml, or exactly
like in CXF - hardcoded in the components:
public class SoapActionInInterceptor extends AbstractSoapInterceptor {

    public SoapActionInInterceptor() {


> Allow more control over SearchComponents ordering in SearchHandler
> ------------------------------------------------------------------
>                 Key: SOLR-1393
>                 URL:
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Grant Ingersoll
>            Priority: Minor
>              Labels: newdev
>             Fix For: 4.3
> It would be useful to be able to add the notion of before/after when declaring search
components.  Currently, you can either explicitly declare all components or insert at the
beginning or end.  It would be nice to be able to say: this new component comes after the
Query component without having to declare all the components.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message