lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-4764) When using NRT, just init the reader from IndexWriter
Date Thu, 25 Apr 2013 18:52:16 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13642072#comment-13642072
] 

Michael McCandless commented on SOLR-4764:
------------------------------------------

+1, this is very costly, because the first NRT open will open an entirely new set of SegmentReaders
(not sharing anything from the non-NRT reader passed in to openIfChanged).

                
> When using NRT, just init the reader from IndexWriter
> -----------------------------------------------------
>
>                 Key: SOLR-4764
>                 URL: https://issues.apache.org/jira/browse/SOLR-4764
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Robert Muir
>
> Spinoff from SOLR-4761
> Solr first opens a DirectoryReader from the directory, then later will pass this to IW
openIfChanged.
> I noticed this when i was confused that mergedsegmentwarmer doesn't appear to work at
first until after you've reopened...
> I'm not totally sure what the current behavior causes (does IW's pool reuse segments
from this passed-in "external" reader, or is this causing some horrible doubling-up/inefficient
stuff etc?). To some extent i think we should change it even if its actually performant: I
think its confusing.
> I think ideally we'd change IndexReaderFactory's method to take writer instead of directory
so that custom DirectoryReaders can still work.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message