lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <>
Subject [jira] [Commented] (LUCENE-4965) Add dynamic numeric range faceting
Date Sun, 28 Apr 2013 19:32:15 GMT


Shai Erera commented on LUCENE-4965:


* Range is not really extendable (private ctor) -- is that intentional? I guess there's not
much point extending it ...

* Any reason why not take primitive values and let the user define e.g Long.MAX_VALUE as an
unlimited upper bound? I'm not a big fan of auto-boxing, and passing null is as good to me
as passing MAX_VAL. User has to make a decision anyway, so might as well be explicit about

* Accumulate() iterates at the outer loop on matchingDocs, and inner loop on ranges. I remember
while writing FacetsAccumulator that luceneutil was happier with the other way (matchingDocs
inner). Maybe test?

* Shouldn't {{if (ranges.ranges.accept(v))}} break if there's a match?
** While at it, maybe RangeSet should sort the ranges by their minimum value? Not sure if
asymptotically this will matter...

* I don't think it matters much, but maybe allocate {{new ArrayList<FacetResultNode>()}}
with {{ranges.ranges.length}}?

I think this we're almost ready!
> Add dynamic numeric range faceting
> ----------------------------------
>                 Key: LUCENE-4965
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 5.0, 4.4
>         Attachments: LUCENE-4965.patch, LUCENE-4965.patch, LUCENE-4965.patch, LUCENE-4965.patch,
> The facet module today requires the app to compute the hierarchy
> at index time, eg a timestamp field might use a year/month/day
> hierarchy.
> While this gives great performance, since it minimizes the search-time
> computation, sometimes it's unfortunately useful/necessary to do things entirely at
> search time, like Solr does.
> E.g. I'm playing with a prototype Lucene search for Jira issues
> and I'd like to add a drill down+sideways for "Updated in past day,
> 2 days, week, month" etc.  But because time is constantly advancing,
> doing this at index time is a not easy ...

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message