lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] [Commented] (LUCENE-4965) Add dynamic numeric range faceting
Date Tue, 30 Apr 2013 10:58:15 GMT


Michael McCandless commented on LUCENE-4965:

bq. You don't use LongRange.accept (for expected counts) b/c that's what you test right? maybe
just drop a one liner?

Right, I'll add a comment.

bq. Also, does the test really need to run atLeast(100) iters? I would think one iteration
is enough, if we let Jenkins periodic builds do the iters for us (plus, someone can run with
-Dtests.iters or -Dtests.dups)

Well it's an efficiency question I guess (how many jenkins iters will
it take to find a bug) ... I have beasted it and it's passing for me
:)  I'll drop it to 10 ... the test is plenty fast.

bq. I think you can remove "nocommit add to example"?
bq. There are some leftover commented out lines (members and ctor)

Woops, fixed!

In the example:
new Date().getTime() can be just System.currentTimeMillis()?
Also, do we really need to index 1000 documents to demo? I ask because it's harder to debug
1000 docs 

Good, I'll switch to currentTimeMillis, and drop it to 100 docs.

Thanks Shai.

> Add dynamic numeric range faceting
> ----------------------------------
>                 Key: LUCENE-4965
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 5.0, 4.4
>         Attachments: LUCENE-4965.patch, LUCENE-4965.patch, LUCENE-4965.patch, LUCENE-4965.patch,
LUCENE-4965.patch, LUCENE-4965.patch, LUCENE-4965.patch, LUCENE-4965.patch
> The facet module today requires the app to compute the hierarchy
> at index time, eg a timestamp field might use a year/month/day
> hierarchy.
> While this gives great performance, since it minimizes the search-time
> computation, sometimes it's unfortunately useful/necessary to do things entirely at
> search time, like Solr does.
> E.g. I'm playing with a prototype Lucene search for Jira issues
> and I'd like to add a drill down+sideways for "Updated in past day,
> 2 days, week, month" etc.  But because time is constantly advancing,
> doing this at index time is a not easy ...

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message