lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Miller <markrmil...@gmail.com>
Subject Re: svn commit: r1498659 - /lucene/dev/trunk/solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java
Date Mon, 01 Jul 2013 20:15:42 GMT
That removes a bunch of testing (replication with other dirs) and test checks…

If you don't mind, I'd like to pull that test into a subclass test.

- Mark

On Jul 1, 2013, at 4:09 PM, yonik@apache.org wrote:

> Author: yonik
> Date: Mon Jul  1 20:09:12 2013
> New Revision: 1498659
> 
> URL: http://svn.apache.org/r1498659
> Log:
> tests: disable MockDirectoryFactory for replication
> 
> Modified:
>    lucene/dev/trunk/solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java
> 
> Modified: lucene/dev/trunk/solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java
> URL: http://svn.apache.org/viewvc/lucene/dev/trunk/solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java?rev=1498659&r1=1498658&r2=1498659&view=diff
> ==============================================================================
> --- lucene/dev/trunk/solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java
(original)
> +++ lucene/dev/trunk/solr/core/src/test/org/apache/solr/handler/TestReplicationHandler.java
Mon Jul  1 20:09:12 2013
> @@ -103,7 +103,7 @@ public class TestReplicationHandler exte
>     super.setUp();
> //    System.setProperty("solr.directoryFactory", "solr.StandardDirectoryFactory");
>     // For manual testing only
> -    // useFactory(null); // force an FS factory
> +    useFactory(null); // force an FS factory.  currently MockDirectoryFactory causes
SolrCore.initIndex to detect no index and create a new one.
>     master = new SolrInstance("master", null);
>     master.setUp();
>     masterJetty = createJetty(master);
> @@ -339,6 +339,21 @@ public class TestReplicationHandler exte
>     }
>   }
> 
> +
> +  /**
> +   * Verify that things still work if an IW has not been opened (and hence the CommitPoints
have not been communicated to the deletion policy)
> +   */
> +  public void testNoWriter() throws Exception {
> +    index(slaveClient, "id", "123456");
> +    slaveClient.commit();
> +    slaveJetty.stop();
> +    // System.err.println("############ starting jetty");
> +    slaveJetty = createJetty(slave);
> +    // System.err.println("############ done starting jetty");
> +    slaveClient = createNewSolrServer(slaveJetty.getLocalPort());
> +    pullFromMasterToSlave();
> +  }
> +
>   /**
>    * Verify that empty commits and/or commits with openSearcher=false 
>    * on the master do not cause subsequent replication problems on the slave 
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message