lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4985) Make it easier to mix different kinds of FacetRequests
Date Mon, 29 Jul 2013 11:53:49 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4985?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13722377#comment-13722377
] 

Michael McCandless commented on LUCENE-4985:
--------------------------------------------

{quote}
I don't know how important it is ... none of our tests depend on it, and it's not clear to
me how to fix it at all. FA.create() is a factory method. If it returns a single Accumulator,
then it happens already (order is maintained). MultiFacetAccum loses the order. Maybe if we
passed it the list of facet requests it could re-order them after accumulation, but I don't
know how important it is... an app can put the List<FacetResult> in a Map, and do lookups?
Also, as a generic MultiFA, it's not easier to determine from which FA a source FacetRequest
came?
{quote}

OK ...

But, I think we should not document that "range facet requests come last"?  Let's leave it
defined as undefined?  Maybe we should return Collection not List?
                
> Make it easier to mix different kinds of FacetRequests
> ------------------------------------------------------
>
>                 Key: LUCENE-4985
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4985
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>            Reporter: Michael McCandless
>             Fix For: 5.0, 4.5
>
>         Attachments: LUCENE-4985.patch, LUCENE-4985.patch, LUCENE-4985.patch
>
>
> Spinoff from LUCENE-4980, where we added a strange class called RangeFacetsAccumulatorWrapper,
which takes an incoming FSP, splits out the FacetRequests into range and non-range, delegates
to two accumulators for each set, and then zips the results back together in order.
> Somehow we should generalize this class and make it work with SortedSetDocValuesAccumulator
as well.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message