lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-4977) info stream in solrconfig should have option for writing to the solr log
Date Mon, 01 Jul 2013 16:34:23 GMT

    [ https://issues.apache.org/jira/browse/SOLR-4977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13696929#comment-13696929
] 

Robert Muir commented on SOLR-4977:
-----------------------------------

patch looks good Ryan. One last question:

Should we change isEnabled to look like this?
{code}
  @Override
  public boolean isEnabled(String component) {
    // ignore testpoints so this can be used with tests without flooding logs with verbose
messages
    return !"TP".equals(component) && log.isInfoEnabled();
  }
{code}

This way IndexWriter doesnt calculate anything if its not configured to log. We could even
consider "enabling" this in solrconfig.xml by default, and instead deferring the control via
the logging system. So we'd turn off logging for LoggingInfoStream in logging.properties by
default, but someone could then turn it on there, or on-the-fly via the admin gui?
                
> info stream in solrconfig should have option for writing to the solr log
> ------------------------------------------------------------------------
>
>                 Key: SOLR-4977
>                 URL: https://issues.apache.org/jira/browse/SOLR-4977
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ryan Ernst
>         Attachments: SOLR-4977.patch, SOLR-4977.patch, SOLR-4977.patch, SOLR-4977.patch,
SOLR-4977.patch, SOLR-4977.patch
>
>
> Having a separate file is annoying, plus the print stream option doesn't rollover on
size or date, doesn't have custom formatting options, etc.  Exactly what the logging lib is
meant to handle.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message