lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Tomás Fernández Löbbe (JIRA) <j...@apache.org>
Subject [jira] [Commented] (SOLR-5028) Incorrect ShardHandlerFactory creation
Date Wed, 10 Jul 2013 18:55:48 GMT

    [ https://issues.apache.org/jira/browse/SOLR-5028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704913#comment-13704913
] 

Tomás Fernández Löbbe commented on SOLR-5028:
---------------------------------------------

if we take this approach we should remove CfgProp.SOLR_SHARDHANDLERFACTORY_CLASS, SOLR_SHARDHANDLERFACTORY_CONNTIMEOUT,
SOLR_SHARDHANDLERFACTORY_NAME, SOLR_SHARDHANDLERFACTORY_SOCKETTIMEOUT so that there is a unique
way to access the SHF information. Specially in 4.x where the path to populate those properties
is incorrect and using them would result in a bug.
                
> Incorrect ShardHandlerFactory creation
> --------------------------------------
>
>                 Key: SOLR-5028
>                 URL: https://issues.apache.org/jira/browse/SOLR-5028
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 5.0, 4.4
>            Reporter: Tomás Fernández Löbbe
>         Attachments: SOLR-5082.patch
>
>
> It seems to me that there are two bugs in the ShardHandlerFactoryCreation that cancel
each other and it seems to be working with the old style solr.xml, but not with the "new style".
ConfigSolrOldXml seems to be expecting the shardHandlerFactory with the xpath:
> solr/shardHandlerFactory/@class
> Instead of solr/*cores*/shardHandlerFactory/@class as it used to be. This is never caught
because in the CoreContainer the ShardHandlerFactory is initialized using "configSolr.getConfig().getNode("solr/cores/shardHandlerFactory",
false);" instead of "configSolr.get(CfgProp.SOLR_SHARDHANDLERFACTORY_CLASS, null);" or something
like that. However, if you use the "new style" xml, the CoreContainer will still try to initialize
the factory like that, and won't find the  SHF. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message