lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LUCENE-5106) unban properties with unicode escapes
Date Fri, 12 Jul 2013 14:59:48 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706987#comment-13706987
] 

Uwe Schindler edited comment on LUCENE-5106 at 7/12/13 2:58 PM:
----------------------------------------------------------------

Then you risk inconsistency, because your patch does not disallow InputStream/OutputStream.
This is why i want the current commited thing for 4.0. Without it, its a blocker, as [~romseygeek]
could commit something similar again.

*I don't want to ban unicode, I want all this legacy code be consistent only*.
                
      was (Author: thetaphi):
    Then you ris inconsistency, because your patch does not disallow InputStream/OutputStream
                  
> unban properties with unicode escapes
> -------------------------------------
>
>                 Key: LUCENE-5106
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5106
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 4.4
>            Reporter: Robert Muir
>            Priority: Blocker
>         Attachments: LUCENE-5106.patch
>
>
> As discussed on the mailing list, its just wrong to ban the use of unicode here.
> This blocks 4.4 (because it was committed there, too)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message