lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (LUCENE-5107) Convert all Properties#store() and load() to use UTF-8 charset
Date Fri, 12 Jul 2013 15:17:48 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706996#comment-13706996
] 

Uwe Schindler edited comment on LUCENE-5107 at 7/12/13 3:17 PM:
----------------------------------------------------------------

In Lucene/Solr 4.5 we only allow the UTF-8 encoded properties files, so Reader/Writer throughout
the code! This allows to still read files written by 4.4 and before with unicode-escapes (the
Reader load(Reader) method decodes unicode-escaped, too). In fact, files written by the InputStream
API are US-ASCII only, with everything >127 escaped (see src.zip) - so can also be loaded
by an UTF-8 decoder, so the change breaks no existing files.
                
      was (Author: thetaphi):
    In Lucene/Solr 4.5 we only allow the UTF-8 encoded properties files, so Reader/Writer
throughout the code! This allows to still read files written by 4.4 and before with unicode-escapes
are still correctly decoded (the Reader load(Reader) method decodes unicode-escaped, too).
In fact, files written by the InputStream API are US-ASCII only, with everything >127 escaped
(see src.zip) - so can also be loaded by an UTF-8 decoder, so the change breaks no existing
files.
                  
> Convert all Properties#store() and load() to use UTF-8 charset
> --------------------------------------------------------------
>
>                 Key: LUCENE-5107
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5107
>             Project: Lucene - Core
>          Issue Type: Task
>    Affects Versions: 4.4
>            Reporter: Uwe Schindler
>            Assignee: Uwe Schindler
>            Priority: Blocker
>             Fix For: 4.5
>
>
> Followup of LUCENE-5106: This needs to be changed and the forbidden signatures changed
to disallow InputStream/OutputStream and allow Reader/Writer only.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message