lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-2548) Multithreaded faceting
Date Tue, 10 Sep 2013 05:31:58 GMT

    [ https://issues.apache.org/jira/browse/SOLR-2548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762750#comment-13762750
] 

David Smiley commented on SOLR-2548:
------------------------------------

bq. If any of the faceting methods are blocked on IO (e.g. docvalues faceting), this will
close file descriptors with NIO/MMAP directory implementations: see the documentation in org.apache.lucene.store
for more information.

Ok; I'll look into that later.

{quote}
> Only the first facet.threads worth of facets are actually done concurrently; the rest
are done serially.

I remember that being my initial reaction too - but then when you think a little about it,
you realize that it's not the case.
{quote}

Aha; now I see it!  This is confusing code -- adding to the completionService/executor in
two different loops; and the 2nd loop is particularly un-obvious to me.

bq. Just as a (likely controversial) suggestion in general here, its hard to "see" the single-threaded
case (which is the most common case).

+0 not controversial to me
                
> Multithreaded faceting
> ----------------------
>
>                 Key: SOLR-2548
>                 URL: https://issues.apache.org/jira/browse/SOLR-2548
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>    Affects Versions: 3.1
>            Reporter: Janne Majaranta
>            Assignee: Erick Erickson
>            Priority: Minor
>              Labels: facet
>             Fix For: 4.5, 5.0
>
>         Attachments: SOLR-2548_4.2.1.patch, SOLR-2548_for_31x.patch, SOLR-2548_multithreaded_faceting,_dsmiley.patch,
SOLR-2548.patch, SOLR-2548.patch, SOLR-2548.patch, SOLR-2548.patch, SOLR-2548.patch, SOLR-2548.patch
>
>
> Add multithreading support for faceting.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message