lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5196) Revive LTC.PREFLEX_IMPERSONATION_IS_ACTIVE
Date Sun, 01 Sep 2013 11:56:52 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13755706#comment-13755706
] 

ASF subversion and git services commented on LUCENE-5196:
---------------------------------------------------------

Commit 1519260 from [~shaie] in branch 'dev/branches/branch_4x'
[ https://svn.apache.org/r1519260 ]

LUCENE-5196: add LuceneTestCase.OLD_FORMAT_IMPERSONATION_IS_ACTIVE
                
> Revive LTC.PREFLEX_IMPERSONATION_IS_ACTIVE
> ------------------------------------------
>
>                 Key: LUCENE-5196
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5196
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Shai Erera
>            Assignee: Shai Erera
>            Priority: Minor
>         Attachments: LUCENE-5196.patch, LUCENE-5196.patch
>
>
> This constant is currently not used and from what I understand, it was used in the past
to test 3.x stuff? Anyway, I want to revive it by renaming it to OLD_FORMAT_IMPERSONATION_IS_ACTIVE
(defaults to true) and have the RWCodecs respect it by not supporting e.g. fieldsConsumer()
if it's set to false. This will allow tests that want to verify e.g. old formats are not supported
work.
> Currently it's impossible because the RWCodec gets loaded before the non-RW by SPI, and
so writing segments in an old format always work. I want to test something like that in LUCENE-5189
and prevents it.
> Will post a patch soon.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message