lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] [Updated] (LUCENE-5202) LookaheadTokenFilter consumes an extra token in nextToken
Date Sat, 07 Sep 2013 23:27:51 GMT


Michael McCandless updated LUCENE-5202:

    Attachment: LUCENE-5202.patch

OK I got the test working ... I had to fix a few things in the test:

  * Move the test classes under lucene/core/src/test ("ant test" did not want to run tests
under lucene/test-framework/src/test)

  * Add an insertToken() call in afterPosition; this [confusingly] notifies the base class
that a new token was inserted.  I also added clearAttributes() call, and set posInc and offsets.

And I also added a missing afterPosition() call in after all tokens are exhausted, in LookaheadTokenFilter.
> LookaheadTokenFilter consumes an extra token in nextToken
> ---------------------------------------------------------
>                 Key: LUCENE-5202
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>    Affects Versions: 4.3.1
>            Reporter: Benson Margulies
>         Attachments: LUCENE-5202.patch, LUCENE-5202.patch
> This is a bit hard to explain except by looking at the test case. I've coded a filter
that uses LookaheadTokenFilter. The incrementToken method peeks some tokens. Then, it seems,
nextToken in the Lookahead class calls peekToken itself, which seems to me to consume a token
so that it's not seen when the derived class sets out to process the next set of tokens.
> In passing, this test case can be used to demonstrate that it does not work to try to
use the afterPosition method to set up attributes of the token that we're 'after'. Probably
that was never intended. However, I'm hoping for some feedback as to whether the rest of the
structure here is as intended for subclasses of LookaheadTokenFilter.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message