lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Endele (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-5230) Call DelegatingCollector.finish() during grouping
Date Wed, 11 Sep 2013 09:32:52 GMT

    [ https://issues.apache.org/jira/browse/SOLR-5230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13764157#comment-13764157
] 

Simon Endele commented on SOLR-5230:
------------------------------------

Applied the patch and it seems to work at a first glance.
Thank you very much for your quick reaction on https://issues.apache.org/jira/browse/SOLR-5020,
Joel!

But for some scenarios (e.g. expensive post-filters) it might be a drawback that the phases
cannot be distinguished in the finish() method.
What do you think about introducing a second method DelegatingCollector.finishAfterGrouping()
or similar that is called in the second phase instead of finish()?
                
> Call DelegatingCollector.finish() during grouping
> -------------------------------------------------
>
>                 Key: SOLR-5230
>                 URL: https://issues.apache.org/jira/browse/SOLR-5230
>             Project: Solr
>          Issue Type: New Feature
>          Components: search
>    Affects Versions: 4.4
>            Reporter: Joel Bernstein
>            Priority: Minor
>             Fix For: 4.5, 5.0
>
>         Attachments: SOLR-5230.patch
>
>
> This is an add-on to SOLR-5020 to call the new DelegatingCollector.finish() method from
inside the grouping flow. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message