lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Yubin Kim (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (LUCENE-5221) SimilarityBase.computeNorm is inconsistent with TFIDFSimilarity
Date Tue, 17 Sep 2013 20:58:15 GMT

     [ https://issues.apache.org/jira/browse/LUCENE-5221?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Yubin Kim updated LUCENE-5221:
------------------------------

    Attachment: LUCENE-5221.patch

Here's the patch.
                
> SimilarityBase.computeNorm is inconsistent with TFIDFSimilarity
> ---------------------------------------------------------------
>
>                 Key: LUCENE-5221
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5221
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/search
>    Affects Versions: 4.4
>            Reporter: Yubin Kim
>              Labels: normalize, search, similarity
>         Attachments: LUCENE-5221.patch
>
>
> {{SimilarityBase.computeNorm}} Javadoc indicates that the doc length should be encoded
in the same way as {{TFIDFSimilarity}}. However, when {{discountOverlaps}} is {{false}}, what
gets encoded is {{SmallFloat.floatToByte315((boost / (float) Math.sqrt(docLen / boost)));}}
rather than  {{SmallFloat.floatToByte315((boost / (float) Math.sqrt(length)));}} due to the
extra {{/ state.getBoost()}} term in {{SimilarityBase.computeNorm}}: 
>   final float numTerms;
>   if (discountOverlaps)
>     numTerms = state.getLength() - state.getNumOverlap();
>   else
>     numTerms = state.getLength() */ state.getBoost();*
>   return encodeNormValue(state.getBoost(), numTerms);

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message