lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Erick Erickson <>
Subject SOLR-5302, Analytics
Date Thu, 07 Nov 2013 13:50:16 GMT

I'm a little overwhelmed by this thing. It's 500K and currently fails
precommit with javadoc warnings. I can fix those bits with some

But, how to proceed? I've no hope of competently reviewing 500K of changes
(some if it is documentation, true). But it obviously have lots and lots of
work put in to it, and I'd like to get moving on getting this checked in.

I'm looking for some consensus here on whether just fixing up the javadocs
and running the test suite is enough to at least check it in to trunk. From
there, letting it bake for a week or two and merging into 4.x (after 4.6 is
cut) would be the next step.

It's new functionality, so it doesn't seem _too_ dangerous.

See, if people don't raise objections, I can spread the blame if things go
wrong :)

View raw message