lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5325) Move ValueSource and FunctionValues under core/
Date Mon, 04 Nov 2013 15:33:21 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13812909#comment-13812909
] 

David Smiley commented on LUCENE-5325:
--------------------------------------

+1 to move ValueSource/FunctionValues to Core.  I've certainly viewed it as a core part of
Lucene.

Adrien, by "improve the multi-valued APIs", are you perhaps referring ValueSource/FunctionValue's
rather odd set of methods that take a 2nd parameter which is an array to dump multiple values
out into?  MultiValueSource goes along with this.  I rather hate MultiValueSource and all
those overloaded methods -- I look forward to seeing a better design.  The main problem with
MultiValueSource is that it's design is limited to all documents having a constant number
of values, it doesn't vary per document.  Notice MultiValueSource's dimension() takes no arguments
-- it's result is effectively constant.

> Move ValueSource and FunctionValues under core/
> -----------------------------------------------
>
>                 Key: LUCENE-5325
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5325
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>            Reporter: Shai Erera
>
> Spinoff from LUCENE-5298: ValueSource and FunctionValues are abstract APIs which exist
under the queries/ module. That causes any module which wants to depend on these APIs (but
not necessarily on any of their actual implementations!), to depend on the queries/ module.
If we move these APIs under core/, we can eliminate these dependencies and add some mock impls
for testing purposes.
> Quoting Robert from LUCENE-5298:
> {quote}
> we should eliminate the suggest/ dependencies on expressions and queries, the expressions/
on queries, the grouping/ dependency on queries, the spatial/ dependency on queries, its a
mess.
> {quote}
> To add to that list, facet/ should not depend on queries too.



--
This message was sent by Atlassian JIRA
(v6.1#6144)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message