lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dawid Weiss (JIRA)" <>
Subject [jira] [Commented] (SOLR-5488) Fix up test failures for Analytics Component
Date Thu, 21 Nov 2013 23:01:36 GMT


Dawid Weiss commented on SOLR-5488:

Hi Houston. I explained the reason for the ordering in my post to the dev list (Jira was down).

Just looking randomly at the code (pretty hairy...) I noticed this in

  public class LocalRequestFactory {
    public String qtype = null;
    public int start = 0;
    public int limit = 1000;
    public Map<String,String> args = new HashMap<String,String>();

We should *not* be using HashMaps for anything that later on requires
iteration over map elements (as this is the case here) because hash
maps are jvm-dependent and pretty much don't have a reliable iteration
order. This should be changed to LinkedHashMap.

... and sure the problem does reproduce 100% if you use IBM J9, as in
the failed build. I would fix the bug first (don't know how :), using
J9 to diagnose the problem, then correct the code not to use the
HashMap order.

Hope this helps you in finding out what the heck is wrong. Install IBM's JVM (J9) and rerun
with the seed from the log above -- the problem reproduces for me all the time. 

> Fix up test failures for Analytics Component
> --------------------------------------------
>                 Key: SOLR-5488
>                 URL:
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 5.0, 4.7
>            Reporter: Erick Erickson
>            Assignee: Erick Erickson
> The analytics component has a few test failures, perhaps environment-dependent. This
is just to collect the test fixes in one place for convenience when we merge back into 4.x

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message