lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michael Busch <busch...@gmail.com>
Subject Re: Make IndexingChain and friends protected?
Date Sat, 08 Mar 2014 01:27:40 GMT
Sounds good. I'll work on a patch.

On 3/7/14 1:05 PM, Michael McCandless wrote:
> +1
>
> Mike McCandless
>
> http://blog.mikemccandless.com
>
>
> On Fri, Mar 7, 2014 at 2:39 PM, Robert Muir <rcmuir@gmail.com> wrote:
>> if the change can mostly just expose the indexing chain and related
>> abstract classe so that its properly pluggable, yet passes our
>> documentation-lint task without unravelling the whole thing and making
>> some of the crazier impl stuff public, I think it could be a change
>> for the better overall.
>>
>>
>> On Fri, Mar 7, 2014 at 2:15 PM, Michael Busch <buschmic@gmail.com> wrote:
>>> Hi All,
>>>
>>> At Twitter we're using customized IndexingChains and also extend a lot of
>>> abstract classes like e.g. TermsHashConsumer.
>>> Most of these classes are currently package-private, because they were
>>> always considered "expert APIs".
>>>
>>> I was wondering if we could switch from package-private to protected in
>>> combination with @lucene.internal? That way extensions and callers of these
>>> APIs would not have to be placed in the o.a.l.index package anymore.
>>>
>>> I'd be happy to work on a patch unless there are concerns about this change.
>>>
>>> Michael
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>>> For additional commands, e-mail: dev-help@lucene.apache.org
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
>> For additional commands, e-mail: dev-help@lucene.apache.org
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
> For additional commands, e-mail: dev-help@lucene.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message