lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5479) Make default dimension config in FacetConfig adjustable
Date Sat, 01 Mar 2014 11:45:20 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13917037#comment-13917037
] 

ASF subversion and git services commented on LUCENE-5479:
---------------------------------------------------------

Commit 1573156 from [~mikemccand] in branch 'dev/trunk'
[ https://svn.apache.org/r1573156 ]

LUCENE-5479: make the default dimension config controllable via subclass of FacetsConfig

> Make default dimension config in FacetConfig adjustable 
> --------------------------------------------------------
>
>                 Key: LUCENE-5479
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5479
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/facet
>            Reporter: Rob Audenaerde
>            Assignee: Michael McCandless
>            Priority: Minor
>         Attachments: LUCENE-5479.patch, LUCENE-5479.patch
>
>
> Now it is hardcoded to DEFAULT_DIM_CONFIG. This may be useful for most standard approaches.

> However, I use lots of facets. These facets can be multivalued, I do not know that on
beforehand. So what I would like to do is to change the default config to {{mulitvalued =
true}}. 
> Currently I have a working, but rather ugly workaround that subclasses FacetConfig, like
this:
> {code:title=CustomFacetConfig.java|borderStyle=solid}
> public class CustomFacetsConfig extends FacetsConfig
> {
> 	public final static DimConfig DEFAULT_D2A_DIM_CONFIG = new DimConfig();
> 	static
> 	{
> 		DEFAULT_D2A_DIM_CONFIG.multiValued = true;
> 	}
> 	@Override
> 	public synchronized DimConfig getDimConfig( String dimName )
> 	{
> 		DimConfig ft = super.getDimConfig( dimName );
> 		if ( DEFAULT_DIM_CONFIG.equals( ft ) )
> 		{
> 			return DEFAULT_D2A_DIM_CONFIG;
> 		}
> 		return ft;
> 	}
> }
> {code}
> I created a patch to illustrate what I would like to change. By making a protected method
it is easier to create a custom subclass of FacetConfig. 
> Also, maybe there are better way to accomplish my goal (easy default to multivalue?)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message