lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (SOLR-5914) Almost all Solr tests no longer cleanup their temp dirs on Windows
Date Thu, 27 Mar 2014 17:45:18 GMT

    [ https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949684#comment-13949684
] 

Mark Miller edited comment on SOLR-5914 at 3/27/14 5:44 PM:
------------------------------------------------------------

bq. Seems like we're doubling efforts here.

I'm not sure - I do know that it took me about 5 min to make that change, so it sounds like
you spent most of your time on something else. I know your solution attempts to deal with
TEMP_DIR and requires looking at 11 tests, some of which won't clean up properly anytime soon.
My cleanup of Solr code to do what it was supposed to do to begin with already works with
all tests.

I look at what you are doing as a larger fix that is needed for the Lucene/Solr test framework
as a whole. I'm happy to help with that later. I'm simply making the Solr cleanup code consistent
with itself.


was (Author: markrmiller@gmail.com):
bq. Seems like we're doubling efforts here.

I'm not sure - I do know that it took me about 5 min to make that change, so it sounds like
you spent most of your time on something else. I know your solution attempts to deal with
TEMP_DIR and requires looking at 11 tests, some of which clean up properly anytime soon. My
cleanup of Solr code to do what it was supposed to begin with already works with all tests.

I look at what you are doing as a larger fix that is need for the Lucene/Solr test framework
as a whole. I'm happy to help with that later. I'm simply making the Solr cleanup code consistent
with itself.

> Almost all Solr tests no longer cleanup their temp dirs on Windows
> ------------------------------------------------------------------
>
>                 Key: SOLR-5914
>                 URL: https://issues.apache.org/jira/browse/SOLR-5914
>             Project: Solr
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 4.8
>            Reporter: Uwe Schindler
>            Assignee: Dawid Weiss
>            Priority: Critical
>             Fix For: 4.8
>
>         Attachments: SOLR-5914 .patch, SOLR-5914 .patch, branch4x-jenkins.png, build-plugin.jpg,
trunk-jenkins.png
>
>
> Recently the Windows Jenkins Build server has the problem of all-the time running out
of disk space. This machine runs 2 workspaces (4.x and trunk) and has initially 8 Gigabytes
of free SSD disk space.
> Because of the recently all-the time failing tests, the test framework does not forcefully
clean up the "J0" working folders after running tests. This leads to the fact, that the workspace
is filled with tons of Solr Home dirs. I tried this on my local machine:
> - run ant test
> - go to build/.../test/J0 and watch folders appearing: Almost every test no longer cleans
up after shutting down, leaving a million of files there. This is approx 3 to 4 Gigabytes!!!
> In Lucene the folders are correctly removed. This has happened recently, so i think we
have some code like ([~erickerickson] !!!):
> {{new Properties().load(new FileInputStream(...))}} that does not close the files. Because
of this, the test's afterClass cannot clean up folders anymore. If you look in the test log,
you see messages like "{{!!!! WARNING: best effort to remove C:\Users\JenkinsSlave\workspace\Lucene-Solr-4.x-Windows\solr\build\solr-core\test\J0\.\org.apache.solr.cloud.TestShortCircuitedRequests-1395693845226
FAILED !!!!!}}" all the time.
> So if anybody committed some changes that might not close files correctly, please fix!
Otherwise I have to disable testing on windows - and I will no longer run solr, tests, too:
My local computer also uses gigabytes of temp space after running tests!



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message