lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Mark Miller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-5914) Almost all Solr tests no longer cleanup their temp dirs on Windows
Date Thu, 27 Mar 2014 21:40:20 GMT

    [ https://issues.apache.org/jira/browse/SOLR-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13949971#comment-13949971
] 

Mark Miller commented on SOLR-5914:
-----------------------------------

{noformat}One clear evidence how broken it was is how many sections of the code tried to either
create timestamp-based temporary folders or delete-recreate folders with a fixed name. This
just sucked.{noformat}

It wasn't even necessary - it was either a wrong or outdated idea - same with the attempts
to delete and then mkdir or deleteOnExit. That's all stuff waiting for improvement. But that
is just sugar - and I'll take sugar man :) Load it on.

I do have issues with how your branch does not deal with the borked dataDir concept, I don't
like that it requires that special util method call everywhere. I really think what you have
done actually simply compliments the fix, I would just do a few things a little differently.
I'll show you how I would merge it up.


> Almost all Solr tests no longer cleanup their temp dirs on Windows
> ------------------------------------------------------------------
>
>                 Key: SOLR-5914
>                 URL: https://issues.apache.org/jira/browse/SOLR-5914
>             Project: Solr
>          Issue Type: Bug
>          Components: Tests
>    Affects Versions: 4.8
>            Reporter: Uwe Schindler
>            Assignee: Dawid Weiss
>            Priority: Critical
>             Fix For: 4.8
>
>         Attachments: SOLR-5914 .patch, SOLR-5914 .patch, branch4x-jenkins.png, build-plugin.jpg,
trunk-jenkins.png
>
>
> Recently the Windows Jenkins Build server has the problem of all-the time running out
of disk space. This machine runs 2 workspaces (4.x and trunk) and has initially 8 Gigabytes
of free SSD disk space.
> Because of the recently all-the time failing tests, the test framework does not forcefully
clean up the "J0" working folders after running tests. This leads to the fact, that the workspace
is filled with tons of Solr Home dirs. I tried this on my local machine:
> - run ant test
> - go to build/.../test/J0 and watch folders appearing: Almost every test no longer cleans
up after shutting down, leaving a million of files there. This is approx 3 to 4 Gigabytes!!!
> In Lucene the folders are correctly removed. This has happened recently, so i think we
have some code like ([~erickerickson] !!!):
> {{new Properties().load(new FileInputStream(...))}} that does not close the files. Because
of this, the test's afterClass cannot clean up folders anymore. If you look in the test log,
you see messages like "{{!!!! WARNING: best effort to remove C:\Users\JenkinsSlave\workspace\Lucene-Solr-4.x-Windows\solr\build\solr-core\test\J0\.\org.apache.solr.cloud.TestShortCircuitedRequests-1395693845226
FAILED !!!!!}}" all the time.
> So if anybody committed some changes that might not close files correctly, please fix!
Otherwise I have to disable testing on windows - and I will no longer run solr, tests, too:
My local computer also uses gigabytes of temp space after running tests!



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message