lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4246) Fix IndexWriter.close() to not commit or wait for pending merges
Date Wed, 02 Apr 2014 14:47:22 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13957706#comment-13957706
] 

Simon Willnauer commented on LUCENE-4246:
-----------------------------------------

I want to revisit this for 4.8! We recently fixed rollback and given what rollback looks like
now I think it should actually be called close since this is what it does it flushes all stuff
and shuts IW down. IMO that is exactly what I would expect close to do. Yet, the simplest
solution to this issue would be rename close to commitAndClose() and rollback to close() and
we are good to go. I guess it's not going to be that simple but after I ran into the issue
today that somebody used a NoMergeScheduler and IW#close() was waiting forever right here:

{code}
- timed waiting on org.apache.lucene.index.IndexWriter@439740e3
	at org.apache.lucene.index.IndexWriter.doWait(IndexWriter.java:4366)
	at org.apache.lucene.index.IndexWriter.waitForMerges(IndexWriter.java:2289)
	at org.apache.lucene.index.IndexWriter.finishMerges(IndexWriter.java:2273)
	at org.apache.lucene.index.IndexWriter.closeInternal(IndexWriter.java:1015)
	at org.apache.lucene.index.IndexWriter.close(IndexWriter.java:932)
{code}

I am even more convinced that we have to fix this soon though.

> Fix IndexWriter.close() to not commit or wait for pending merges
> ----------------------------------------------------------------
>
>                 Key: LUCENE-4246
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4246
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Robert Muir
>             Fix For: 4.8
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message