lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Simon Willnauer (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4246) Fix IndexWriter.close() to not commit or wait for pending merges
Date Fri, 04 Apr 2014 10:39:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13959856#comment-13959856
] 

Simon Willnauer commented on LUCENE-4246:
-----------------------------------------

hey mike I like the compromise we are using here! I have a few comments on this "small" patch
:)

 * In IW#shutdown should we do commit() and close in a try finally manner or rollback if commit
throws an exception?
 * I don't think we should use a string to message if we have uncommitted can you use a boolean
for this?
 * the pendingCommit check in IW#shutdown() is just  double safety / fail early logic right
?
 * so IW#shutdown will wait for merges by default if you don't want this you have to do that
yourself, call abort merges, commit & close?

I think this change clarifies the semantics a lot! Thanks for working on it.

> Fix IndexWriter.close() to not commit or wait for pending merges
> ----------------------------------------------------------------
>
>                 Key: LUCENE-4246
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4246
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Michael McCandless
>             Fix For: 4.8
>
>         Attachments: LUCENE-4246.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message