lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shikhar Bhushan (JIRA)" <>
Subject [jira] [Commented] (LUCENE-4370) Let Collector know when all docs have been collected
Date Sun, 06 Apr 2014 12:17:15 GMT


Shikhar Bhushan commented on LUCENE-4370:

Proposal: {{LeafCollector}} (in trunk via LUCENE-5527) gets a method {{void finish();}

Semantics: It is invoked when collection with that leaf has completed. It is not invoked if
collection does terminates due to an exception.

I know this ticket was originally about having such a method on {{Collector}} and not at the
segment-level collection, however I think all use cases can be cleanly modelled in this manner.

As naming goes, I think {{finish()}} or {{done()}} or such is better than {{close()}}, which
implies a try-finally'esque construct.

/cc [~jpountz] [~rcmuir] [~hossman]

> Let Collector know when all docs have been collected
> ----------------------------------------------------
>                 Key: LUCENE-4370
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>    Affects Versions: 4.0-BETA
>            Reporter: Tomás Fernández Löbbe
>            Priority: Minor
> Collectors are a good point for extension/customization of Lucene/Solr, however sometimes
it's necessary to know when the last document has been collected (for example, for flushing
cached data).
> It would be nice to have a method that gets called after the last doc has been collected.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message