lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5570) FSDirectory's fsync() is lenient
Date Fri, 04 Apr 2014 18:22:33 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13960228#comment-13960228
] 

ASF subversion and git services commented on LUCENE-5570:
---------------------------------------------------------

Commit 1584860 from rmuir@apache.org in branch 'dev/trunk'
[ https://svn.apache.org/r1584860 ]

LUCENE-5570: don't let fsync create new zero-byte files

> FSDirectory's fsync() is lenient
> --------------------------------
>
>                 Key: LUCENE-5570
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5570
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: core/store
>            Reporter: Robert Muir
>         Attachments: LUCENE-5570.patch, LUCENE-5570.patch, LUCENE-5570_zerobyte.patch
>
>
> This method has a lot of problems:
> 1. it tracks 'stale files' as it writes (this seems pointless), and only actually fsyncs
the intersection of that 'stale files' and the filenames passed as argument to sync(). So
any bogus names passed to sync() are just silently ignored
> 2. if "something bad happens" (e.g. two indexwriters/dirs on the same path, or some other
shenanigans), and the file is actually in stale files, but was say actually deleted on the
filesystem, the underlying fsync() call will create a new 0-byte file and fsync that.
> In my opinion we should do none of this. we should throw exceptions when this stuff is
wrong.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message