lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shawn Heisey (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-5981) Please change method visibility of getSolrWriter in DataImportHandler to public (or at least protected)
Date Wed, 16 Apr 2014 04:20:16 GMT

    [ https://issues.apache.org/jira/browse/SOLR-5981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13970405#comment-13970405
] 

Shawn Heisey commented on SOLR-5981:
------------------------------------

Switching to git has been discussed on the dev list quite recently.  There is widespread support
for the idea, but a very vocal minority opposition as well.

There are two main git mirrors of the subversion repo, one at apache and one at github.  Search
for "lucene" on this page for links to both of them:

http://git.apache.org/


> Please change method visibility of getSolrWriter in DataImportHandler to public (or at
least protected)
> -------------------------------------------------------------------------------------------------------
>
>                 Key: SOLR-5981
>                 URL: https://issues.apache.org/jira/browse/SOLR-5981
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>    Affects Versions: 4.0
>         Environment: Linux 3.13.9-200.fc20.x86_64
> Solr 4.6.0
>            Reporter: Aaron LaBella
>            Assignee: Shawn Heisey
>            Priority: Minor
>             Fix For: 4.8, 5.0
>
>         Attachments: SOLR-5981.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> I've been using the org.apache.solr.handler.dataimport.DataImportHandler for a bit and
it's an excellent model and architecture.  I'd like to extend the usage of it to plugin my
own DIHWriter, but, the code doesn't allow for it.  Please change ~line 227 in the DataImportHander
class to be:
> public SolrWriter getSolrWriter
> instead of:
> private SolrWriter getSolrWriter
> or, at a minimum, protected, so that I can extend DataImportHandler and override this
method.
> Thank you *sincerely* in advance for the quick turn-around on this.  If the change can
be made in 4.6.0 and upstream, that'd be ideal.
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message