lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5618) DocValues updates send wrong fieldinfos to codec producers
Date Mon, 28 Apr 2014 10:14:15 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13982888#comment-13982888
] 

Robert Muir commented on LUCENE-5618:
-------------------------------------

{quote}
Write each updated field in its own gen – if you update many fields, many times, this will
create many files in the index directory. Technically it's not "wrong", it just looks weird
{quote}

Why? This is how separate norms worked. Its the obvious solution. The current behavior is
broken: lets fix the bug. This optimization is what is to blame. The optimization is invalid.

{quote}
Anyway, I think the issue's title is wrong – DocValues updates do pass the correct fieldInfos
to the producers. They pass only the infos that the producer should care about, and we see
that passing too many is wrong (PerFieldDVF).
{quote}

Absolutely not! You get a different fieldinfos at _read_ time than you get at _write_. This
is broken!

> DocValues updates send wrong fieldinfos to codec producers
> ----------------------------------------------------------
>
>                 Key: LUCENE-5618
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5618
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>
> Spinoff from LUCENE-5616.
> See the example there, docvalues readers get a fieldinfos, but it doesn't contain the
correct ones, so they have invalid field numbers at read time.
> This should really be fixed. Maybe a simple solution is to not write "batches" of fields
in updates but just have only one field per gen? 
> This removes many-many relationships and would make things easy to understand.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message