lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Ernst (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-5999) Solr should expose setCheckIntegrityAtMerge in indexConfig
Date Mon, 21 Apr 2014 22:23:19 GMT

    [ https://issues.apache.org/jira/browse/SOLR-5999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13976118#comment-13976118
] 

Ryan Ernst commented on SOLR-5999:
----------------------------------

This looks great! Two minor comments on the test:
* You don't need the @Test annotation
* Your test function can throw Exception, instead of having try/catch.

> Solr should expose setCheckIntegrityAtMerge in indexConfig
> ----------------------------------------------------------
>
>                 Key: SOLR-5999
>                 URL: https://issues.apache.org/jira/browse/SOLR-5999
>             Project: Solr
>          Issue Type: New Feature
>            Reporter: Varun Thacker
>             Fix For: 4.9, 5.0
>
>         Attachments: SOLR-5999.patch
>
>
> LUCENE-2446 added checksums to Lucene segment files. We could expose CheckIntegrityAtMerge
in the indexConfig tag in solrconfig.xml.
> Something like - 
> {noformat}
>      <!--
> 		Use true to enable this safety check, which can help
>    		reduce the risk of propagating index corruption from older segments 
>    		into new ones, at the expense of slower merging.
>      -->
>      <checkIntegrityAtMerge>false</checkIntegrityAtMerge>
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message