lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michael McCandless (JIRA)" <>
Subject [jira] [Updated] (LUCENE-5628) SpecialOperations.getFiniteStrings should not recurse
Date Thu, 24 Apr 2014 15:38:16 GMT


Michael McCandless updated LUCENE-5628:

    Attachment: LUCENE-5628.patch

New patch, with some simplification: I moved all the hairy logic about next label/transition
into the PathNode.  I think this helps.

I put a nocommit to use Stack instead of PathNode[] ... this would be simpler (push/pop instead
of .get/.remove) ... the only backside is it would mean new Java object on each push vs now
where it re-uses.

> SpecialOperations.getFiniteStrings should not recurse
> -----------------------------------------------------
>                 Key: LUCENE-5628
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.9, 5.0
>         Attachments: LUCENE-5628.patch, LUCENE-5628.patch, LUCENE-5628.patch
> Today it consumes one Java stack frame per transition, which when used by AnalyzingSuggester
is per character in each token.  This can lead to stack overflows if you have a long suggestion.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message