lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <>
Subject [jira] [Updated] (LUCENE-4371) consider refactoring slicer to indexinput.slice
Date Sat, 17 May 2014 04:24:14 GMT


Robert Muir updated LUCENE-4371:

    Attachment: LUCENE-4371.patch

Cleaned up patch (as trunk has changed much), I think I'm happy with this one:

Just a summary:

* Remove IndexInputSlicer and Directory.createSlicer()
* Add abstract IndexInput.slice(), behaves like clone(), but takes offset and length
* MMap, NIOFS, SimpleFS just clone with adjusted offset.
* MMap "slice-of-slice" assert (cfs within cfs) is removed because Lucene40DocValues does
this, and slicing a slice now does what you think (before you got the default buffering impl
over mmap...)
* the previous "Default impl" is moved to BufferedIndexInput.wrap(). Its only used by RAMdir
and a few other wierd ones. This makes it explicit they are using buffering wrapper for CFS.

> consider refactoring slicer to indexinput.slice
> -----------------------------------------------
>                 Key: LUCENE-4371
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-4371.patch, LUCENE-4371.patch, LUCENE-4371.patch, LUCENE-4371.patch
> From LUCENE-4364:
> {quote}
> In my opinion, we should maybe check, if we can remove the whole Slicer in all Indexinputs?
Just make the slice(...) method return the current BufferedIndexInput-based one. This could
be another issue, once this is in.
> {quote}

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message