lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uwe Schindler (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4371) consider refactoring slicer to indexinput.slice
Date Sat, 17 May 2014 08:48:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000715#comment-14000715
] 

Uwe Schindler commented on LUCENE-4371:
---------------------------------------

Btw, thanks for hiding and making the concrete FSDirIndexInputs hidden and especially final!
Great step. The protected annoyed me for long time, but for backwards compatibility I never
removed them (although I am sure nobody was ever able to subclass them correctly!).

In ByteBufferIndexInput.slice() the return value is a package-protected class, so we should
change this to the general IndexInput like in the abstract base class, otherwise the Javadocs
will be look broken. This applies to the other classes and their clone(), too. The caller
only needs the abstract IndexInput (especially if the impl class is invisible).

> consider refactoring slicer to indexinput.slice
> -----------------------------------------------
>
>                 Key: LUCENE-4371
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4371
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-4371.patch, LUCENE-4371.patch, LUCENE-4371.patch, LUCENE-4371.patch
>
>
> From LUCENE-4364:
> {quote}
> In my opinion, we should maybe check, if we can remove the whole Slicer in all Indexinputs?
Just make the slice(...) method return the current BufferedIndexInput-based one. This could
be another issue, once this is in.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message