lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-4371) consider refactoring slicer to indexinput.slice
Date Sat, 17 May 2014 10:54:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-4371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000737#comment-14000737
] 

Robert Muir commented on LUCENE-4371:
-------------------------------------

{quote}
We should add @Override here, because it now implements abstract method.
{quote}

Oh, thanks, I forgot this.

{quote}
I think we use the same FileDescriptor, so we also don't need to close the slices?
{quote}

Slices are just like clones. So for example CFSDirectory holds an input over the entire .cfs
file, and when you ask to open a "file" within the cfs it returns a slice (clone) of it. when
you close the cfs it closes the real one.

{quote}
In ByteBufferIndexInput.slice() the return value is a package-protected class, so we should
change this to the general IndexInput like in the abstract base class, otherwise the Javadocs
will be look broken. 
{quote}

What javadocs? This is not a public class :)

> consider refactoring slicer to indexinput.slice
> -----------------------------------------------
>
>                 Key: LUCENE-4371
>                 URL: https://issues.apache.org/jira/browse/LUCENE-4371
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Robert Muir
>         Attachments: LUCENE-4371.patch, LUCENE-4371.patch, LUCENE-4371.patch, LUCENE-4371.patch
>
>
> From LUCENE-4364:
> {quote}
> In my opinion, we should maybe check, if we can remove the whole Slicer in all Indexinputs?
Just make the slice(...) method return the current BufferedIndexInput-based one. This could
be another issue, once this is in.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message