lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5618) DocValues updates send wrong fieldinfos to codec producers
Date Sun, 18 May 2014 06:03:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14001008#comment-14001008
] 

Shai Erera commented on LUCENE-5618:
------------------------------------

Thanks Rob!

bq. My only concern (which can be a followup issue), is to try to simplify a lot of stuff
in SegmentReader.initDocValuesProducers

I tried, but I didn't see it simplifies a lot. However, I now took a second look and I think
what prevents the simplification in the no-updates case is the API on SegDocValues, which
insists on getting a List<FieldInfo> rather than FieldInfos. I will try to change the
API (it's internal) and hopefully it will allow to have a simple {{if (!si.hasFieldUpdates())}}
code block.

bq. For example today this is doing two hash lookups, when this method could just try 'dvFields'
first and optimize the common case.

Where do you see the two hash lookups? Only in the first getNumeric() there are two hash lookups,
but after that it's always one. Or did I miss something?

> DocValues updates send wrong fieldinfos to codec producers
> ----------------------------------------------------------
>
>                 Key: LUCENE-5618
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5618
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Shai Erera
>            Priority: Blocker
>             Fix For: 4.9
>
>         Attachments: LUCENE-5618.patch, LUCENE-5618.patch
>
>
> Spinoff from LUCENE-5616.
> See the example there, docvalues readers get a fieldinfos, but it doesn't contain the
correct ones, so they have invalid field numbers at read time.
> This should really be fixed. Maybe a simple solution is to not write "batches" of fields
in updates but just have only one field per gen? 
> This removes many-many relationships and would make things easy to understand.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message