lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shai Erera (JIRA)" <>
Subject [jira] [Updated] (LUCENE-5618) DocValues updates send wrong fieldinfos to codec producers
Date Sun, 18 May 2014 07:23:16 GMT


Shai Erera updated LUCENE-5618:

    Attachment: LUCENE-5618.patch

I modified SegDocValues API to take FieldInfos, and SegReader.initDocValues now distinguishes
between no-updates, with updates and back-compat logic. I wish we didn't have the back-compat
case, but that's what we have.

I'm still unsure about the getNumeric inefficiencies that you mentioned, so if you can clarify
I will try to address them here too. If it's a general SR refactoring and simplification,
I agree that we should pursue that in a separate issue.

> DocValues updates send wrong fieldinfos to codec producers
> ----------------------------------------------------------
>                 Key: LUCENE-5618
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>            Assignee: Shai Erera
>            Priority: Blocker
>             Fix For: 4.9
>         Attachments: LUCENE-5618.patch, LUCENE-5618.patch, LUCENE-5618.patch
> Spinoff from LUCENE-5616.
> See the example there, docvalues readers get a fieldinfos, but it doesn't contain the
correct ones, so they have invalid field numbers at read time.
> This should really be fixed. Maybe a simple solution is to not write "batches" of fields
in updates but just have only one field per gen? 
> This removes many-many relationships and would make things easy to understand.

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message