lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shalin Shekhar Mangar (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (SOLR-6013) Fix method visibility of Evaluator, refactor DateFormatEvaluator for extensibility
Date Thu, 01 May 2014 09:03:15 GMT

     [ https://issues.apache.org/jira/browse/SOLR-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Shalin Shekhar Mangar updated SOLR-6013:
----------------------------------------

    Attachment: SOLR-6013.patch

Thanks Aaron. Here's a single patch with all your changes. We typically attach a patch named
as SOLR-xxx.patch and if/when we need to revise, we upload patch with the same name again.
Jira will automatically gray out the older patches in the UI. This makes it easier to know
the latest patch.

I made three changes:
# FileListEntityProcessor.getDate was missing a return statement
# I removed the getters for VariableWrapper and made the attributes public final
# Changed DateFormatCacheKey to static protected.

I will commit this shortly.

> Fix method visibility of Evaluator, refactor DateFormatEvaluator for extensibility
> ----------------------------------------------------------------------------------
>
>                 Key: SOLR-6013
>                 URL: https://issues.apache.org/jira/browse/SOLR-6013
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>    Affects Versions: 4.7
>            Reporter: Aaron LaBella
>             Fix For: 4.9
>
>         Attachments: 0001-add-getters-for-datemathparser.patch, 0001-change-method-access-to-protected.patch,
0001-change-method-variable-visibility-and-refactor-for-extensibility.patch, SOLR-6013.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> This is similar to issue 5981, the Evaluator class is declared as abstract, yet the parseParams
method is package private?  Surely this is an oversight, as I wouldn't expect everyone writing
their own evaluators to have to deal with parsing the parameters.
> Similarly, I needed to refactor DateFormatEvaluator because I need to do some custom
date math/parsing and it wasn't written in a way that I can extend it.
> Please review/apply my attached patch to the next version of Solr, ie: 4.8 or 4.9 if
I must wait.
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message