lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shalin Shekhar Mangar (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SOLR-6013) Fix method visibility of Evaluator, refactor DateFormatEvaluator for extensibility
Date Mon, 05 May 2014 14:48:15 GMT

    [ https://issues.apache.org/jira/browse/SOLR-6013?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13989563#comment-13989563
] 

Shalin Shekhar Mangar commented on SOLR-6013:
---------------------------------------------

bq.  you forgot two of the public 'getter' methods that I added in the last patch to Evaluator.VariableWrapper

No, I didn't. Those two are now public final fields.

> Fix method visibility of Evaluator, refactor DateFormatEvaluator for extensibility
> ----------------------------------------------------------------------------------
>
>                 Key: SOLR-6013
>                 URL: https://issues.apache.org/jira/browse/SOLR-6013
>             Project: Solr
>          Issue Type: Improvement
>          Components: contrib - DataImportHandler
>    Affects Versions: 4.7
>            Reporter: Aaron LaBella
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 4.9, 5.0
>
>         Attachments: 0001-add-getters-for-datemathparser.patch, 0001-change-method-access-to-protected.patch,
0001-change-method-variable-visibility-and-refactor-for-extensibility.patch, SOLR-6013.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> This is similar to issue 5981, the Evaluator class is declared as abstract, yet the parseParams
method is package private?  Surely this is an oversight, as I wouldn't expect everyone writing
their own evaluators to have to deal with parsing the parameters.
> Similarly, I needed to refactor DateFormatEvaluator because I need to do some custom
date math/parsing and it wasn't written in a way that I can extend it.
> Please review/apply my attached patch to the next version of Solr, ie: 4.8 or 4.9 if
I must wait.
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message