lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Ernst (JIRA)" <>
Subject [jira] [Commented] (LUCENE-5650) createTempDir and associated functions no longer create
Date Wed, 21 May 2014 17:02:40 GMT


Ryan Ernst commented on LUCENE-5650:

+1, everything looks good to me (and test pass for me as well).

> createTempDir and associated functions no longer create
> ----------------------------------------------------------------------
>                 Key: LUCENE-5650
>                 URL:
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: general/test
>            Reporter: Ryan Ernst
>            Assignee: Dawid Weiss
>            Priority: Minor
>             Fix For: 4.9, 5.0
>         Attachments: LUCENE-5650.patch, LUCENE-5650.patch, LUCENE-5650.patch, LUCENE-5650.patch,
> The recent refactoring to all the create temp file/dir functions (which is great!) has
a minor regression from what existed before.  With the old {{LuceneTestCase.TEMP_DIR}}, the
directory was created if it did not exist.  So, if you set {{}} to {{"./temp"}},
then it would create that dir within the per jvm working dir.  However, {{getBaseTempDirForClass()}}
now does asserts that check the dir exists, is a dir, and is writeable.
> Lucene uses {{"."}} as {{}}.  Then in the test security manager, the per
jvm cwd has read/write/execute permissions.  However, this allows tests to write to their
cwd, which I'm trying to protect against (by setting cwd to read/execute in my test security

This message was sent by Atlassian JIRA

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message