lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5659) SpecialOperations.isFinite hits StackOverflowError on automaton accepting long strings
Date Sat, 10 May 2014 22:16:38 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13993525#comment-13993525
] 

Robert Muir commented on LUCENE-5659:
-------------------------------------

Thanks for the explanation. I opened an issue for the real bug here: LUCENE-5660

We should also maybe revert 5628 in my opinion. This stuff is abuse of the automaton pkg for
what its not designed to do, like trying to use a linked list as a hashmap. 


> SpecialOperations.isFinite hits StackOverflowError on automaton accepting long strings
> --------------------------------------------------------------------------------------
>
>                 Key: LUCENE-5659
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5659
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>             Fix For: 4.9, 5.0
>
>         Attachments: LUCENE-5659.patch
>
>
> Just like we fixed getFiniteStrings to not consume stack in proportion to the longest
string accepted by the automaton (LUCENE-5628), isFinite has the same limitation.  The fix
is pretty simple; I just share the code from getFiniteStrings, but allocate two BitSets up
front like the current impl.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message