lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Muir (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5663) Fix FSDirectory.open API
Date Sat, 17 May 2014 02:33:14 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000631#comment-14000631
] 

Robert Muir commented on LUCENE-5663:
-------------------------------------

If it smells bad, its the code calling the shadowed methods that is smelly. so they could
throw exception...

> Fix FSDirectory.open API
> ------------------------
>
>                 Key: LUCENE-5663
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5663
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>
> Spinoff from LUCENE-5658
> {quote}
> This does not use NIOFSDir! open() is a static factory method on FSDirectory, just inherited
to NIOFSDirectory. 
> {quote}
> I think its confusing we have this method on FSDirectory, so its visible in subclasses.
We should at least consider doing this in another way so its not confusing.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message