lucene-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "David Smiley (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (LUCENE-5666) Add UninvertingReader
Date Sat, 17 May 2014 12:58:15 GMT

    [ https://issues.apache.org/jira/browse/LUCENE-5666?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14000782#comment-14000782
] 

David Smiley commented on LUCENE-5666:
--------------------------------------

Oh, right.  I'll repost it here for everyone's benefit:
{noformat}
* LUCENE-5666: Change uninverted access (sorting, faceting, grouping, etc)
  to use the DocValues API instead of FieldCache. For FieldCache functionality,
  use UninvertingReader in lucene/misc (or implement your own FilterReader).
  UninvertingReader is more efficient: supports multi-valued numeric fields,
  detects when a multi-valued field is single-valued, reuses caches
  of compatible types (e.g. SORTED also supports BINARY and SORTED_SET access
  without insanity).  "Insanity" is no longer possible unless you explicitly want it. 
  Rename FieldCache* and DocTermOrds* classes in the search package to DocValues*. 
  Move SortedSetSortField to core and add SortedSetFieldSource to queries/, which
  takes the same selectors. Add helper methods to DocValues.java that are better 
  suited for search code (never return null, etc).  (Mike McCandless, Robert Muir)
{noformat}

I looked up DocValues which is new to me but the commit message references LUCENE-5573 which
seems mis-attributed. I'm kinda surprised FieldCache isn't deprecated.  It could be marked
\@lucene.internal.  At least... it's name doesn't seem appropriate anymore.  Maybe UninvertedCache.
But perhaps a rename like that would introduce too much change for now, even though it's trunk.
 It could use some javadocs stating that DocValues.java should generally be used instead.

> Add UninvertingReader
> ---------------------
>
>                 Key: LUCENE-5666
>                 URL: https://issues.apache.org/jira/browse/LUCENE-5666
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Robert Muir
>             Fix For: 5.0
>
>         Attachments: LUCENE-5666.patch
>
>
> Currently the fieldcache is not pluggable at all. It would be better if everything used
the docvalues apis.
> This would allow people to customize the implementation, extend the classes with custom
subclasses with additional stuff, etc etc.
> FieldCache can be accessed via the docvalues apis, using the FilterReader api.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org


Mime
View raw message